Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread Pranit Bauva
On Wed, Mar 16, 2016 at 2:46 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> ... But then I am still not convinced for the >> requirement of another variable `opt-verbose` as I believe that the >> `verbose` and `config_verbose` are quite enough for this. >> ... Or is there something else wh

Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread Junio C Hamano
Pranit Bauva writes: > ... But then I am still not convinced for the > requirement of another variable `opt-verbose` as I believe that the > `verbose` and `config_verbose` are quite enough for this. > ... Or is there something else which I forgot to > consider? I do not think we need three varia

Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread Pranit Bauva
On Wed, Mar 16, 2016 at 1:54 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> First one to introduce a new variable `config_verbose` to store the >> value read by the config. Till then the value of verbose can be set >> through command line options. Depending on the situation as you >> descr

Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread Junio C Hamano
Pranit Bauva writes: > First one to introduce a new variable `config_verbose` to store the > value read by the config. Till then the value of verbose can be set > through command line options. Depending on the situation as you > described, it can then make the modification. Another approach would

Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread Pranit Bauva
On Wed, Mar 16, 2016 at 12:54 AM, Eric Sunshine wrote: >> As Eric Sunshine mentioned ($gmane.org/288811), it would react >> according to the multiple verbosity level and since its not currently >> defined in `commit` it will react as it is reacting when verbosity >> level is 1. > > I get the feeli

Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread Eric Sunshine
On Tue, Mar 15, 2016 at 3:00 PM, Pranit Bauva wrote: > On Tue, Mar 15, 2016 at 5:01 PM, SZEDER Gábor wrote: >> You made 'commit.verbose' a boolean, so either verbose or not, ... >> ... but note these context lines telling us that --verbose can be >> specified not just once but twice (and who know

Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread Pranit Bauva
On Tue, Mar 15, 2016 at 5:01 PM, SZEDER Gábor wrote: > You made 'commit.verbose' a boolean, so either verbose or not, ... > ... but note these context lines telling us that --verbose can be > specified not just once but twice (and who knows what the future may > bring). This raises some not enti

Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread SZEDER Gábor
> Add commit.verbose configuration variable as a convenience for those > who always prefer --verbose. > > Helped-by: Eric Sunshine > Signed-off-by: Pranit Bauva > > --- > The previous versions of this patch are: > - [v6] $gmane/288811 > - [v5] $gmane/288728 > - [v4] $gmane/288652 > - [v3] $

[PATCH v7] commit: add a commit.verbose config variable

2016-03-14 Thread Pranit Bauva
Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Eric Sunshine Signed-off-by: Pranit Bauva --- The previous versions of this patch are: - [v6] $gmane/288811 - [v5] $gmane/288728 - [v4] $gmane/288652 - [v3] $gmane/288634 - [v2] $gm