Felipe Contreras wrote:
> When a reviewer reaches that point, (s)he usually says: other than
> cosmetic preferences: Reviewed-by: me.
Yes, you can have a Reviewed-by from me if you want.
And yes, it is appropriate not to CC me on v8 and v9, since I have no
further comments.
--
To unsubscribe from
On Fri, May 31, 2013 at 3:03 AM, Ramkumar Ramachandra
wrote:
> Felipe Contreras wrote:
>> I was going to make these stylistic changes to make you happy, but
>> then I realized the only that does really make sense is to change msg
>> = nil to msg = false, and it's not even worth to waste a thought
Felipe Contreras wrote:
> I was going to make these stylistic changes to make you happy, but
> then I realized the only that does really make sense is to change msg
> = nil to msg = false, and it's not even worth to waste a thought on
> changes like that.
We don't have existing Ruby code in git.gi
On Thu, May 30, 2013 at 6:31 AM, Felipe Contreras
wrote:
> On Thu, May 30, 2013 at 4:01 AM, Ramkumar Ramachandra
> Not a single one of these comments makes a difference at all, all of
> them can wait until after the patch is merged, many of them are a
> matter of preferences, and some of them hav
On Thu, May 30, 2013 at 7:08 AM, Ramkumar Ramachandra
wrote:
> Felipe Contreras wrote:
>> What's your objective? Block this patch from ever going in?
>>
>> Not a single one of these comments makes a difference at all, all of
>> them can wait until after the patch is merged, many of them are a
>> m
Felipe Contreras wrote:
> What's your objective? Block this patch from ever going in?
>
> Not a single one of these comments makes a difference at all, all of
> them can wait until after the patch is merged, many of them are a
> matter of preferences, and some of them have already been addressed as
On Thu, May 30, 2013 at 4:01 AM, Ramkumar Ramachandra
wrote:
> Let's do one more review.
>
> Felipe Contreras wrote:
>> diff --git a/contrib/related/git-related b/contrib/related/git-related
>> new file mode 100755
>> index 000..1b9b1e7
>> --- /dev/null
>> +++ b/contrib/related/git-related
>>
Let's do one more review.
Felipe Contreras wrote:
> diff --git a/contrib/related/git-related b/contrib/related/git-related
> new file mode 100755
> index 000..1b9b1e7
> --- /dev/null
> +++ b/contrib/related/git-related
> @@ -0,0 +1,120 @@
> +#!/usr/bin/env ruby
> +
> +# This script finds peopl
This script find people that might be interested in a patch, by going
back through the history for each single hunk modified, and finding
people that reviewed, acknowledge, signed, or authored the code the
patch is modifying.
It does this by running 'git blame' incrementally on each hunk, and then
9 matches
Mail list logo
