Re: [PATCH v6b 5/8] branch: drop non-commit error reporting

2015-09-25 Thread Karthik Nayak
On Fri, Sep 25, 2015 at 9:30 PM, Junio C Hamano wrote: > Matthieu Moy writes: > >> Karthik Nayak writes: >> >>> Remove the error "branch '%s' does not point at a commit" in >>> apppend_ref() which reports branch refs which do not point to >>> commits. Also remove the error "some refs could not b

Re: [PATCH v6b 5/8] branch: drop non-commit error reporting

2015-09-25 Thread Matthieu Moy
Junio C Hamano writes: > While I was trying to address your "actually already report", I > spotted a typo and then found that the early part of the second > paragraph is a bit hard, so here is what I ended up with. LGTM. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from t

Re: [PATCH v6b 5/8] branch: drop non-commit error reporting

2015-09-25 Thread Junio C Hamano
Matthieu Moy writes: > Karthik Nayak writes: > >> Remove the error "branch '%s' does not point at a commit" in >> apppend_ref() which reports branch refs which do not point to >> commits. Also remove the error "some refs could not be read" in >> print_ref_list() which is triggered as a consequen

Re: [PATCH v6b 5/8] branch: drop non-commit error reporting

2015-09-24 Thread Matthieu Moy
Karthik Nayak writes: > Remove the error "branch '%s' does not point at a commit" in > apppend_ref() which reports branch refs which do not point to > commits. Also remove the error "some refs could not be read" in > print_ref_list() which is triggered as a consequence of the first > error. > > T

[PATCH v6b 5/8] branch: drop non-commit error reporting

2015-09-24 Thread Karthik Nayak
Remove the error "branch '%s' does not point at a commit" in apppend_ref() which reports branch refs which do not point to commits. Also remove the error "some refs could not be read" in print_ref_list() which is triggered as a consequence of the first error. This seems to be the wrong codepath wh