Re: [PATCH v6 5/7] submodule: fix segmentation fault in submodule--helper clone

2016-02-29 Thread Jacob Keller
On Mon, Feb 29, 2016 at 3:20 PM, Stefan Beller wrote: > > I think this bug was put in, by "literally" translating from shell, > see ee8838d15776, where the shell code was rewritten to C, > specially: > > git clone $quiet ${depth:+"$depth"} -n ${reference:+"$reference"} \ > --separate-git-dir

Re: [PATCH v6 5/7] submodule: fix segmentation fault in submodule--helper clone

2016-02-29 Thread Stefan Beller
On Mon, Feb 29, 2016 at 2:58 PM, Jacob Keller wrote: > From: Jacob Keller > > The git submodule--helper clone command will fail with a segmentation > fault when given a null url or null path variable. Since these are > required for proper functioning of the submodule--helper clone > subcommand, a

[PATCH v6 5/7] submodule: fix segmentation fault in submodule--helper clone

2016-02-29 Thread Jacob Keller
From: Jacob Keller The git submodule--helper clone command will fail with a segmentation fault when given a null url or null path variable. Since these are required for proper functioning of the submodule--helper clone subcommand, add checks to prevent running and fail gracefully when missing. U