Benoît Person writes:
> Another idea crossed my mind: for now the test suite creates a symlink
> of git-remote-mediawiki in the toplevel if it's not installed. It
> would be better to use the bin-wrapper in the testsuite I think ?
Absolutely. The symlink was a dirty hack waiting for a better sol
> GIT_ROOT_DIR=../../..
> GIT_EXEC_PATH=$(cd "$(dirname "$0")" && cd ${GIT_ROOT_DIR} && pwd)
> GIT_MEDIAWIKI="$GIT_EXEC_PATH"/contrib/mw-to-git
> PATH="$GIT_MEDIAWIKI"/contrib/mw-to-git:"$PATH"
> GPLEXTRA="$GIT_MEDIAWIKI"/contrib/mw-to-git
>
> exec "${GIT_EXEC_PATH}/bin-wrappers/git" "$@"
Should I
Benoît Person writes:
>> Two possible alternatives:
>>
>> - Is there a reason you would not want to "install" whatever Perl
>>modules you want to "use" via GITPERLLIB mechanism to
>>../../perl/blib/lib?
> If we are making modifications to Git/Mediawiki.pm or even git-mw.perl
> / git-remo
> As far as I can tell, the only real reason why you need this and
> cannot use ../../bin-wrappers/git directly is because the GITPERLLIB
> it gives you only points at ../../perl/blib/lib and not this
> directory.
Plus (forgot to mention it in the other mail :/ ) it enables us to not
"copy" git-mw
Junio C Hamano writes:
> As far as I can tell, the only real reason why you need this and
> cannot use ../../bin-wrappers/git directly is because the GITPERLLIB
> it gives you only points at ../../perl/blib/lib and not this
> directory.
Not only. You also need to have contrib/mw-to-git/ in the $
benoit.per...@ensimag.fr writes:
> diff --git a/contrib/mw-to-git/bin-wrapper/git
> b/contrib/mw-to-git/bin-wrapper/git
> new file mode 100755
> index 000..aa714a5
> --- /dev/null
> +++ b/contrib/mw-to-git/bin-wrapper/git
> @@ -0,0 +1,27 @@
> +#!/bin/sh
> +
> +# git executable wrapper script
From: Benoit Person
The introduction of the Git::Mediawiki package makes it impossible to test,
without installation, git-remote-mediawiki and git-mw.
Using a git bin-wrapper enables us to define proper $GITPERLLIB to force the
use of the developement version of the Git::Mediawiki package, bypas
7 matches
Mail list logo
