Re: [PATCH v6 2/2] test-config: Add tests for the config_set API

2014-07-09 Thread Matthieu Moy
Tanay Abhra writes: > On 7/7/2014 10:34 PM, Matthieu Moy wrote: >> Tanay Abhra writes: >> >>> diff --git a/t/t1308-config-hash.sh b/t/t1308-config-hash.sh >>> new file mode 100755 >>> index 000..ad99f8b >>> --- /dev/null >>> +++ b/t/t1308-config-hash.sh >>> +test_expect_success 'setup defau

Re: [PATCH v6 2/2] test-config: Add tests for the config_set API

2014-07-09 Thread Tanay Abhra
On 7/7/2014 10:34 PM, Matthieu Moy wrote: > Tanay Abhra writes: > >> diff --git a/t/t1308-config-hash.sh b/t/t1308-config-hash.sh >> new file mode 100755 >> index 000..ad99f8b >> --- /dev/null >> +++ b/t/t1308-config-hash.sh >> +test_expect_success 'setup default config' ' >> +cat >.git

Re: [PATCH v6 2/2] test-config: Add tests for the config_set API

2014-07-07 Thread Matthieu Moy
Tanay Abhra writes: > diff --git a/t/t1308-config-hash.sh b/t/t1308-config-hash.sh > new file mode 100755 > index 000..ad99f8b > --- /dev/null > +++ b/t/t1308-config-hash.sh > @@ -0,0 +1,168 @@ > +#!/bin/sh > + > +test_description='Test git config-hash API in different settings' You may want

[PATCH v6 2/2] test-config: Add tests for the config_set API

2014-07-07 Thread Tanay Abhra
Expose the `config_set` C API as a set of simple commands in order to facilitate testing. Add tests for the `config_set` API as well as for `git_config_get_*()` family for the usual config files. Signed-off-by: Tanay Abhra --- .gitignore | 1 + Makefile | 1 + t/t13