(cc-ing the reporter)
Brandon Williams wrote:
> In some situations run-command will incorrectly try (and fail) to
> execute a directory instead of an executable. For example:
>
> Lets suppose a user has PATH=~/bin (where 'bin' is a directory) and they
> happen to have another directory inside 'bi
On Mon, Apr 24, 2017 at 05:17:24PM -0700, Jonathan Nieder wrote:
> > This is due to only checking 'access()' when locating an executable in
> > PATH, which doesn't distinguish between files and directories. Instead
> > use 'stat()' and check that the path is to a regular file. Now
> > run-comman
Junio C Hamano wrote:
> Jonathan Nieder writes:
>> Until we switched from using execvp to execve, the symptom was very
>> subtle: it only affected the error message when a program could not be
>> found, instead of affecting functionality more substantially.
>
> Hmph, what if you had bin/ssh/ dire
Jonathan Nieder writes:
> Until we switched from using execvp to execve, the symptom was very
> subtle: it only affected the error message when a program could not be
> found, instead of affecting functionality more substantially.
Hmph, what if you had bin/ssh/ directory and bin2/ssh executable
Brandon Williams writes:
> This is due to only checking 'access()' when locating an executable in
> PATH, which doesn't distinguish between files and directories. Instead
> use 'stat()' and check that the path is to a regular file. Now
> run-command won't try to execute the directory 'git-remot
Brandon Williams wrote:
> In some situations run-command will incorrectly try (and fail) to
> execute a directory instead of an executable. For example:
>
> Lets suppose a user has PATH=~/bin (where 'bin' is a directory) and they
> happen to have another directory inside 'bin' named 'git-remote-b
In some situations run-command will incorrectly try (and fail) to
execute a directory instead of an executable. For example:
Lets suppose a user has PATH=~/bin (where 'bin' is a directory) and they
happen to have another directory inside 'bin' named 'git-remote-blah'.
Then git tries to execute th
7 matches
Mail list logo
