Re: [PATCH v6 1/1] http: Add Accept-Language header if possible

2014-12-29 Thread Junio C Hamano
Eric Sunshine writes: > Just a few comments and observations below. Alone, they are not > necessarily worth a re-roll, but if you happen to re-roll for some > other reason, perhaps take them into consideration. I actually think everything you said in this review makes sense and will make the res

Re: [PATCH v6 1/1] http: Add Accept-Language header if possible

2014-12-24 Thread Eric Sunshine
On Mon, Dec 22, 2014 at 11:44 AM, Yi EungJun wrote: > From: Yi EungJun > > Add an Accept-Language header which indicates the user's preferred > languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. > > Examples: > LANGUAGE= -> "" > LANGUAGE=ko:en -> "Accept-Language: ko, en;q=0.9,

Re: [PATCH v6 1/1] http: Add Accept-Language header if possible

2014-12-22 Thread Junio C Hamano
Yi EungJun writes: > From: Yi EungJun > > Add an Accept-Language header which indicates the user's preferred > languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. > > Examples: > LANGUAGE= -> "" > LANGUAGE=ko:en -> "Accept-Language: ko, en;q=0.9, *;q=0.1" > LANGUAGE=ko LANG=en

[PATCH v6 1/1] http: Add Accept-Language header if possible

2014-12-22 Thread Yi EungJun
From: Yi EungJun Add an Accept-Language header which indicates the user's preferred languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. Examples: LANGUAGE= -> "" LANGUAGE=ko:en -> "Accept-Language: ko, en;q=0.9, *;q=0.1" LANGUAGE=ko LANG=en_US.UTF-8 -> "Accept-Language: ko, *;