Re: [PATCH v6 07/27] checkout: inform the user when removing branch state

2019-07-04 Thread Duy Nguyen
On Wed, Jul 3, 2019 at 12:51 AM Junio C Hamano wrote: > > Duy Nguyen writes: > > > I agree, this is not "canceling". I think this series causes conflicts > > with pw/clean-sequencer-state-upon-final-commit and the warning is > > accidentally enabled (partly my fault since I named the argument > >

Re: [PATCH v6 07/27] checkout: inform the user when removing branch state

2019-07-02 Thread Junio C Hamano
Duy Nguyen writes: > I agree, this is not "canceling". I think this series causes conflicts > with pw/clean-sequencer-state-upon-final-commit and the warning is > accidentally enabled (partly my fault since I named the argument > "verbose"). > > Junio, in this conflict resolution (merging nd/swit

Re: [PATCH v6 07/27] checkout: inform the user when removing branch state

2019-07-02 Thread SZEDER Gábor
On Tue, Jul 02, 2019 at 04:03:09PM +0700, Duy Nguyen wrote: > On Tue, Jul 02, 2019 at 10:06:11AM +0200, SZEDER Gábor wrote: > > On Fri, Mar 29, 2019 at 05:38:59PM +0700, Nguyễn Thái Ngọc Duy wrote: > > > After a successful switch, if a merge, cherry-pick or revert is ongoing, > > > it is canceled.

Re: [PATCH v6 07/27] checkout: inform the user when removing branch state

2019-07-02 Thread Duy Nguyen
On Tue, Jul 02, 2019 at 10:06:11AM +0200, SZEDER Gábor wrote: > On Fri, Mar 29, 2019 at 05:38:59PM +0700, Nguyễn Thái Ngọc Duy wrote: > > After a successful switch, if a merge, cherry-pick or revert is ongoing, > > it is canceled. This behavior has been with us from the very early > > beginning, so

Re: [PATCH v6 07/27] checkout: inform the user when removing branch state

2019-07-02 Thread SZEDER Gábor
On Fri, Mar 29, 2019 at 05:38:59PM +0700, Nguyễn Thái Ngọc Duy wrote: > After a successful switch, if a merge, cherry-pick or revert is ongoing, > it is canceled. This behavior has been with us from the very early > beginning, soon after git-merge was created but never actually > documented [1]. It

[PATCH v6 07/27] checkout: inform the user when removing branch state

2019-03-29 Thread Nguyễn Thái Ngọc Duy
After a successful switch, if a merge, cherry-pick or revert is ongoing, it is canceled. This behavior has been with us from the very early beginning, soon after git-merge was created but never actually documented [1]. It may be a good idea to be transparent and tell the user if some operation is c