Re: [PATCH v6 04/11] for-each-ref: add '--points-at' option

2015-06-29 Thread Karthik Nayak
On Mon, Jun 29, 2015 at 11:16 PM, Junio C Hamano wrote: > Karthik Nayak writes: > >> Add the '--points-at' option provided by 'ref-filter'. The option >> lets the user to pick only refs which point to a particular >> commit. > > It somehow feels strange that the option name is points-at and all >

Re: [PATCH v6 04/11] for-each-ref: add '--points-at' option

2015-06-29 Thread Karthik Nayak
On Tue, Jun 30, 2015 at 12:08 AM, Junio C Hamano wrote: > Karthik Nayak writes: > >> +test_expect_success 'check signed tags with --points-at' ' >> + cat >expect <<-\EOF && >> + refs/heads/side >> + refs/tags/four >> + refs/tags/signed-tag four >> + EOF >> + git for-each-r

Re: [PATCH v6 04/11] for-each-ref: add '--points-at' option

2015-06-29 Thread Junio C Hamano
Karthik Nayak writes: > +test_expect_success 'check signed tags with --points-at' ' > + cat >expect <<-\EOF && > + refs/heads/side > + refs/tags/four > + refs/tags/signed-tag four > + EOF > + git for-each-ref --format="%(refname) %(*subject)" --points-at=side > >actual &&

Re: [PATCH v6 04/11] for-each-ref: add '--points-at' option

2015-06-29 Thread Junio C Hamano
Karthik Nayak writes: > Add the '--points-at' option provided by 'ref-filter'. The option > lets the user to pick only refs which point to a particular > commit. It somehow feels strange that the option name is points-at and all the explanation (like the above and also in the doc) talks about po

[PATCH v6 04/11] for-each-ref: add '--points-at' option

2015-06-25 Thread Karthik Nayak
Add the '--points-at' option provided by 'ref-filter'. The option lets the user to pick only refs which point to a particular commit. Add documentation and tests for the same. Based-on-patch-by: Jeff King Mentored-by: Christian Couder Mentored-by: Matthieu Moy Signed-off-by: Karthik Nayak ---