On Fri, Feb 26, 2016 at 2:27 AM, David Turner wrote:
> but -Wshadow produces a ton of complaints on the rest of git's
> code. We should probably fix those.
I know, but what I wrote was meant for new code only (e.g. make
refs/lmdb-backend.o CFLAGS=-Wshadow is clean). I think renaming the
global
On Thu, Feb 25, 2016 at 11:27 AM, David Turner wrote:
> On Thu, 2016-02-25 at 19:57 +0700, Duy Nguyen wrote:
>> A couple of build warnings I found, haven't really read the code yet.
>> These two can easily be fixed
>>
>> refs/lmdb-backend.c: In function 'lmdb_read_raw_ref':
>> refs/lmdb-backend.c:
On Thu, 2016-02-25 at 00:08 +, Ramsay Jones wrote:
> > Ramsay Jones (1):
> > refs: reduce the visibility of do_for_each_ref()
>
> Ah, sorry if it wasn't clear, but there is no need to keep this
> as a separate patch - it should simply be squashed into the relevant
> patch in your series.
>
On Thu, 2016-02-25 at 19:57 +0700, Duy Nguyen wrote:
> A couple of build warnings I found, haven't really read the code yet.
> These two can easily be fixed
>
> refs/lmdb-backend.c: In function 'lmdb_read_raw_ref':
> refs/lmdb-backend.c:554:16: warning: unused variable 'err' [-Wunused
> -variable]
A couple of build warnings I found, haven't really read the code yet.
These two can easily be fixed
refs/lmdb-backend.c: In function 'lmdb_read_raw_ref':
refs/lmdb-backend.c:554:16: warning: unused variable 'err' [-Wunused-variable]
struct strbuf err = STRBUF_INIT;
^
refs/lmdb-ba
On 24/02/16 22:58, David Turner wrote:
> This version incorporates fixes for function scope from Ramsay Jones.
>
> It breaks patches down a bit more, to make them easier to review and
> understand. Michael Haggerty had some suggestions here.
>
> As suggested by Duy Nguyen, it replaces the resol
This version incorporates fixes for function scope from Ramsay Jones.
It breaks patches down a bit more, to make them easier to review and
understand. Michael Haggerty had some suggestions here.
As suggested by Duy Nguyen, it replaces the resolve_ref_unsafe backend
method with read_raw_ref, movin
7 matches
Mail list logo
