Re: [PATCH v6 00/11] Fix icase grep on non-ascii

2016-06-22 Thread Junio C Hamano
Junio C Hamano writes: > I think somebody's implementation of "echo" is not POSIX kosher. Oops, I misspoke. s/POSIX/XSI/; obviously. But the conclusion is the same. echo '\\\tA' may say \\\tA or backslash HT A, depending on the system, so we cannot rely on that in tests that are meant to be p

Re: [PATCH v6 00/11] Fix icase grep on non-ascii

2016-06-22 Thread Junio C Hamano
On Wed, Jun 22, 2016 at 11:41 AM, Duy Nguyen wrote: > On Wed, Jun 22, 2016 at 8:36 PM, Junio C Hamano wrote: >> On Wed, Jun 22, 2016 at 11:29 AM, Duy Nguyen wrote: >>> >>> Can any shell wizards explain this to me? With this code >>> >>> BS=\\ >>> echo ${BS}${BS} >>> >>> Debian's dash returns a s

Re: [PATCH v6 00/11] Fix icase grep on non-ascii

2016-06-22 Thread Duy Nguyen
On Wed, Jun 22, 2016 at 8:36 PM, Junio C Hamano wrote: > On Wed, Jun 22, 2016 at 11:29 AM, Duy Nguyen wrote: >> >> Can any shell wizards explain this to me? With this code >> >> BS=\\ >> echo ${BS}${BS} >> >> Debian's dash returns a single backslash while bash returns two >> backslashes. Section

Re: [PATCH v6 00/11] Fix icase grep on non-ascii

2016-06-22 Thread Junio C Hamano
On Wed, Jun 22, 2016 at 11:29 AM, Duy Nguyen wrote: > > Can any shell wizards explain this to me? With this code > > BS=\\ > echo ${BS}${BS} > > Debian's dash returns a single backslash while bash returns two > backslashes. Section 2.2.1 [1] does not say anything about one > backslash (hidden behi

Re: [PATCH v6 00/11] Fix icase grep on non-ascii

2016-06-22 Thread Duy Nguyen
On Sat, Jun 18, 2016 at 2:26 AM, Duy Nguyen wrote: > On Sat, Jun 18, 2016 at 6:17 AM, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> v6 fixes comments from Ramsay and Eric. Interdiff below. >> >> Another thing I noticed with this is that the non-ascii test breaks >> when run under

Re: [PATCH v6 00/11] Fix icase grep on non-ascii

2016-06-17 Thread Duy Nguyen
On Sat, Jun 18, 2016 at 6:17 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> v6 fixes comments from Ramsay and Eric. Interdiff below. > > Another thing I noticed with this is that the non-ascii test breaks > when run under dash (but passes under bash). You need to have is_IS > loc

Re: [PATCH v6 00/11] Fix icase grep on non-ascii

2016-06-17 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > v6 fixes comments from Ramsay and Eric. Interdiff below. Another thing I noticed with this is that the non-ascii test breaks when run under dash (but passes under bash). You need to have is_IS locale on the system to see the breakage, it seems (which is why I did

Re: [PATCH v6 00/11] Fix icase grep on non-ascii

2016-02-07 Thread Eric Sunshine
On Fri, Feb 5, 2016 at 9:02 PM, Nguyễn Thái Ngọc Duy wrote: > v6 fixes comments from Ramsay and Eric. Interdiff below. The only > thing to add is, I decided not to replace !icase_non_ascii with > icase_ascii_only. I went with spelling out "!icase || ascii_only". I > think it expresses the intentio

[PATCH v6 00/11] Fix icase grep on non-ascii

2016-02-05 Thread Nguyễn Thái Ngọc Duy
v6 fixes comments from Ramsay and Eric. Interdiff below. The only thing to add is, I decided not to replace !icase_non_ascii with icase_ascii_only. I went with spelling out "!icase || ascii_only". I think it expresses the intention better. diff --git a/grep.c b/grep.c index 2e4f71d..aed4fe0 100644