Re: [PATCH v6 0/8] port branch.c to use the filtering part of ref-filter.

2015-09-23 Thread Karthik Nayak
On Thu, Sep 24, 2015 at 12:46 AM, Junio C Hamano wrote: > Matthieu Moy writes: > >> The series looks good to me. I did a minor remark on PATCH 5/8 but this >> should not block inclusion. > > Thanks. As long as the log message is telling the truth, I do not > mind the actual lossage of the error

Re: [PATCH v6 0/8] port branch.c to use the filtering part of ref-filter.

2015-09-23 Thread Junio C Hamano
Matthieu Moy writes: > The series looks good to me. I did a minor remark on PATCH 5/8 but this > should not block inclusion. Thanks. As long as the log message is telling the truth, I do not mind the actual lossage of the error message shown to the user. -- To unsubscribe from this list: send

Re: [PATCH v6 0/8] port branch.c to use the filtering part of ref-filter.

2015-09-23 Thread Matthieu Moy
Karthik Nayak writes: > --- a/builtin/branch.c > +++ b/builtin/branch.c > @@ -479,8 +479,6 @@ static void print_ref_list(struct ref_filter *filter, > struct ref_sorting *sortin > struct ref_array array; > int maxwidth = 0; > const char *remote_prefix = ""; > - struct ref_so

[PATCH v6 0/8] port branch.c to use the filtering part of ref-filter.

2015-09-23 Thread Karthik Nayak
The previous iteration of the same can be found: http://www.mail-archive.com/git@vger.kernel.org/msg78153.html Changes in this version: * use ref_default_sorting() * Improve documentation, comments and commit message. Karthik Nayak (8): branch: refactor width computation branch: bump get_head