Re: [PATCH v6] git-p4: add config git-p4.pathEncoding

2015-09-03 Thread Junio C Hamano
Lars Schneider writes: > On 03 Sep 2015, at 19:03, Junio C Hamano wrote: > >> I'm tempted to suggest squashing the following in. Thoughts? > > OK. The diff looks good to me. For some reason I can’t apply the > patch though. git patch gives me "fatal: corrupt patch at line > 10”. Any idea? (I mi

Re: [PATCH v6] git-p4: add config git-p4.pathEncoding

2015-09-03 Thread Lars Schneider
On 03 Sep 2015, at 19:03, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> +test_expect_success 'Clone repo containing iso8859-1 encoded paths without >> git-p4.pathEncoding' ' >> +git p4 clone --destination="$git" //depot && >> +test_when_finished cleanup_git && >> +(

Re: [PATCH v6] git-p4: add config git-p4.pathEncoding

2015-09-03 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > +test_expect_success 'Clone repo containing iso8859-1 encoded paths without > git-p4.pathEncoding' ' > + git p4 clone --destination="$git" //depot && > + test_when_finished cleanup_git && > + ( > + cd "$git" && > + UTF8="$(pri

[PATCH v6] git-p4: add config git-p4.pathEncoding

2015-09-03 Thread larsxschneider
From: Lars Schneider Perforce keeps the encoding of a path as given by the originating OS. Git expects paths encoded as UTF-8. Add a config to tell git-p4 what encoding Perforce had used for the paths. This encoding is used to transcode the paths to UTF-8. As an example, Perforce on Windows often

[PATCH v6] git-p4: add config git-p4.pathEncoding

2015-09-03 Thread larsxschneider
From: Lars Schneider Diff to v5: * use "test_config" (Thanks Remi! I am still learning all the tools...) * removed whitespaces (Thanks Luke! I added this to my "generate patch" script. Won't happen again :-) * added ACK from Luke (I interpreted "Looks good to me" that way. I hope this is OK.)