Re: [PATCH v6] commit: add a commit.verbose config variable

2016-03-14 Thread Eric Sunshine
On Mon, Mar 14, 2016 at 5:21 PM, Eric Sunshine wrote: > This is missing the important "-c commit.verbose=false". Without it, I meant "-c commit.verbose=true", of course. > you're not really testing anything interesting. > > (It was missing in the "something like this" example test I typed > dire

Re: [PATCH v6] commit: add a commit.verbose config variable

2016-03-14 Thread Eric Sunshine
On Mon, Mar 14, 2016 at 5:21 PM, Eric Sunshine wrote: >> +test_expect_success 'status ignores commit.verbose=true' ' >> + git status >actual && > > This is missing the important "-c commit.verbose=false". Without it, > you're not really testing anything interesting. > > (It was missing in th

Re: [PATCH v6] commit: add a commit.verbose config variable

2016-03-14 Thread Eric Sunshine
On Mon, Mar 14, 2016 at 4:50 PM, Pranit Bauva wrote: > Add commit.verbose configuration variable as a convenience for those > who always prefer --verbose. > > Helped-by: Eric Sunshine > Signed-off-by: Pranit Bauva > --- > diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh > index

[PATCH v6] commit: add a commit.verbose config variable

2016-03-14 Thread Pranit Bauva
Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Eric Sunshine Signed-off-by: Pranit Bauva --- The previous versions of this patch are: - [v5] $gmane/288728 - [v4] $gmane/288652 - [v3] $gmane/288634 - [v2] $gmane/288569 - [v1] $gm