Re: [PATCH v6] Add an explicit GIT_DIR to the list of excludes

2014-06-13 Thread Junio C Hamano
Pasha Bolokhov writes: >>> + test_cmp status.actual.2 status.expect.2 >> >> It is customary to call the files 'expect' and 'actual'. Furthermore, >> swap the order so that in case of a failure the diff shows how the >> actual text was changed from the expected text: >> >>

Re: [PATCH v6] Add an explicit GIT_DIR to the list of excludes

2014-06-13 Thread Pasha Bolokhov
>> + test_cmp status.actual.2 status.expect.2 > > It is customary to call the files 'expect' and 'actual'. Furthermore, > swap the order so that in case of a failure the diff shows how the > actual text was changed from the expected text: > > test_cmp status.expect.2 sta

Re: [PATCH v6] Add an explicit GIT_DIR to the list of excludes

2014-06-11 Thread Johannes Sixt
Am 12.06.2014 01:28, schrieb Pasha Bolokhov: > +test_expect_success "setup" ' > + mkdir repo-inside/ && > + ( > + cd repo-inside/ && > + for f in a b c d > + do > + echo "DATA" >"$f" || exit 1 > + done && > + mk

[PATCH v6] Add an explicit GIT_DIR to the list of excludes

2014-06-11 Thread Pasha Bolokhov
When an explicit '--git-dir' option points to a directory inside the work tree, git treats it as if it were any other directory. In particular, 'git status' lists it as untracked, while 'git add -A' stages the metadata directory entirely Add GIT_DIR to the list of excludes in a dedicated function