Re: [PATCH v5 5/6] grep: enable recurse-submodules to work on objects

2016-11-22 Thread Brandon Williams
On 11/22, Junio C Hamano wrote: > Brandon Williams writes: > > >> > So this change may have an impact on "git ls-tree -r" with pathspec; > >> > I offhand do not know if that impact is undesirable or not. A test > >> > or two may be in order to illustrate what happens? With a submodule > >> > at

Re: [PATCH v5 5/6] grep: enable recurse-submodules to work on objects

2016-11-22 Thread Junio C Hamano
Brandon Williams writes: >> > So this change may have an impact on "git ls-tree -r" with pathspec; >> > I offhand do not know if that impact is undesirable or not. A test >> > or two may be in order to illustrate what happens? With a submodule >> > at "sub/module", running "git ls-tree -r HEAD

Re: [PATCH v5 5/6] grep: enable recurse-submodules to work on objects

2016-11-22 Thread Brandon Williams
On 11/22, Brandon Williams wrote: > On 11/22, Junio C Hamano wrote: > > Brandon Williams writes: > > > > > diff --git a/tree-walk.c b/tree-walk.c > > > index 828f435..ff77605 100644 > > > --- a/tree-walk.c > > > +++ b/tree-walk.c > > > @@ -1004,6 +1004,19 @@ static enum interesting do_match(const

Re: [PATCH v5 5/6] grep: enable recurse-submodules to work on objects

2016-11-22 Thread Brandon Williams
On 11/22, Junio C Hamano wrote: > Brandon Williams writes: > > > diff --git a/tree-walk.c b/tree-walk.c > > index 828f435..ff77605 100644 > > --- a/tree-walk.c > > +++ b/tree-walk.c > > @@ -1004,6 +1004,19 @@ static enum interesting do_match(const struct > > name_entry *entry, > >

Re: [PATCH v5 5/6] grep: enable recurse-submodules to work on objects

2016-11-22 Thread Junio C Hamano
Brandon Williams writes: > diff --git a/tree-walk.c b/tree-walk.c > index 828f435..ff77605 100644 > --- a/tree-walk.c > +++ b/tree-walk.c > @@ -1004,6 +1004,19 @@ static enum interesting do_match(const struct > name_entry *entry, >*/ >

[PATCH v5 5/6] grep: enable recurse-submodules to work on objects

2016-11-22 Thread Brandon Williams
Teach grep to recursively search in submodules when provided with a object. This allows grep to search a submodule based on the state of the submodule that is present in a commit of the super project. When grep is provided with a object, the name of the object is prefixed to all output. In orde