Re: [PATCH v5 4/7] rewrite git_config() to use the config-set API

2014-07-31 Thread Matthieu Moy
Tanay Abhra writes: > + if (!kv_info->linenr) > + die("unable to parse '%s' from command-line > config", entry->key); > + else > + die("bad config variable '%s' at file line %d > in %s", Also two mi

[PATCH v5 4/7] rewrite git_config() to use the config-set API

2014-07-31 Thread Tanay Abhra
Of all the functions in `git_config*()` family, `git_config()` has the most invocations in the whole code base. Each `git_config()` invocation causes config file rereads which can be avoided using the config-set API. Use the config-set API to rewrite `git_config()` to use the config caching layer