Re: [PATCH v5 4/5] setup: Add 'abspath_part_inside_repo' function

2014-02-04 Thread Martin Erik Werner
On Tue, 2014-02-04 at 10:09 -0800, Junio C Hamano wrote: > Martin Erik Werner writes: (...) > > I was trying to convey that if path is simply "/dir/repo", then the while > > loop method of replacing a '/' and checking from the beginning won't > > work for the last level, since it has no terminatin

Re: [PATCH v5 4/5] setup: Add 'abspath_part_inside_repo' function

2014-02-04 Thread Junio C Hamano
Martin Erik Werner writes: > Will you add that test or should I place it in the series with you as > author? Either is fine. Thanks. > On Mon, Feb 03, 2014 at 01:00:48PM -0800, Junio C Hamano wrote: >> Martin Erik Werner writes: >> >> > The path being exactly equal to the work tree is handle

Re: [PATCH v5 4/5] setup: Add 'abspath_part_inside_repo' function

2014-02-03 Thread Martin Erik Werner
On Mon, Feb 03, 2014 at 11:52:33AM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > > Can we have that "git foo $path" to the testsuite as well? That is > > the breakage we do not want to repeat in the future by regressing. > > Something like this, perhaps? > > t/t3004-ls-files-basic

Re: [PATCH v5 4/5] setup: Add 'abspath_part_inside_repo' function

2014-02-03 Thread Junio C Hamano
Martin Erik Werner writes: > The path being exactly equal to the work tree is handled separately, > since then there is no directory separator between the work tree and > in-repo part. What is an "in-repo part"? Whatever it is, I am not sure if I follow that logic. After the while (*path) loop

[PATCH v5 4/5] setup: Add 'abspath_part_inside_repo' function

2014-02-02 Thread Martin Erik Werner
In order to extract the part of an absolute path which lies inside the repo, it is not possible to directly use real_path, since that would dereference symlinks both outside and inside the work tree. Add an 'abspath_part_inside_repo' function which first checks if the work tree is already the pref