Re: [PATCH v5 4/5] pack-redundant: consistent sort method

2019-01-10 Thread SZEDER Gábor
On Thu, Jan 10, 2019 at 08:01:41PM +0800, Jiang Xin wrote: > diff --git a/builtin/pack-redundant.c b/builtin/pack-redundant.c > index 56591d283f..e9d2586e2e 100644 > --- a/builtin/pack-redundant.c > +++ b/builtin/pack-redundant.c > @@ -421,16 +422,22 @@ static inline off_t pack_set_bytecount(struc

[PATCH v5 4/5] pack-redundant: consistent sort method

2019-01-10 Thread Jiang Xin
From: Jiang Xin SZEDER reported that test case t5323 has different test result on MacOS. This is because `cmp_pack_list_reverse` cannot give identical result when two pack being sorted has the same size of remaining_objects. Changes to the sorting function will make consistent test result for t5