Re: [PATCH v5 4/4] commit: Add commit.verbose configuration

2014-06-16 Thread Junio C Hamano
Caleb Thompson writes: >> Again, what are we testing, exactly? >> >> We do not want to see "^diff --git" in the output file, in other >> words, we want to make sure "^diff --git" does not appear in the >> output. >> >> So >> >> write_script check-for-no-diff <<-\EOF >> ! grep '^di

Re: [PATCH v5 4/4] commit: Add commit.verbose configuration

2014-06-16 Thread Caleb Thompson
On Mon, Jun 16, 2014 at 01:06:45PM -0700, Junio C Hamano wrote: > Caleb Thompson writes: > > > On Fri, Jun 13, 2014 at 10:48:55AM -0700, Junio C Hamano wrote: > >> Caleb Thompson writes: > >> > >> > diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh > >> > index 35a4d06..402d6a1 1

Re: [PATCH v5 4/4] commit: Add commit.verbose configuration

2014-06-16 Thread Junio C Hamano
Caleb Thompson writes: > On Fri, Jun 13, 2014 at 10:48:55AM -0700, Junio C Hamano wrote: >> Caleb Thompson writes: >> >> > diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh >> > index 35a4d06..402d6a1 100755 >> > --- a/t/t7507-commit-verbose.sh >> > +++ b/t/t7507-commit-verbose.

Re: [PATCH v5 4/4] commit: Add commit.verbose configuration

2014-06-16 Thread Caleb Thompson
On Mon, Jun 16, 2014 at 02:50:57PM -0500, Caleb Thompson wrote: > On Fri, Jun 13, 2014 at 10:48:55AM -0700, Junio C Hamano wrote: > > Caleb Thompson writes: > > > > > diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh > > > index 35a4d06..402d6a1 100755 > > > --- a/t/t7507-commit-v

Re: [PATCH v5 4/4] commit: Add commit.verbose configuration

2014-06-16 Thread Caleb Thompson
On Fri, Jun 13, 2014 at 10:48:55AM -0700, Junio C Hamano wrote: > Caleb Thompson writes: > > > diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh > > index 35a4d06..402d6a1 100755 > > --- a/t/t7507-commit-verbose.sh > > +++ b/t/t7507-commit-verbose.sh > > @@ -7,6 +7,10 @@ write_scr

Re: [PATCH v5 4/4] commit: Add commit.verbose configuration

2014-06-13 Thread Junio C Hamano
Caleb Thompson writes: > diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh > index 35a4d06..402d6a1 100755 > --- a/t/t7507-commit-verbose.sh > +++ b/t/t7507-commit-verbose.sh > @@ -7,6 +7,10 @@ write_script check-for-diff <<-'EOF' > exec grep '^diff --git' "$1" > EOF > > +

[PATCH v5 4/4] commit: Add commit.verbose configuration

2014-06-12 Thread Caleb Thompson
Add a new configuration variable commit.verbose to implicitly pass --verbose to git-commit. Ensure that --no-verbose to git-commit negates that setting. Signed-off-by: Caleb Thompson --- Documentation/config.txt | 5 + Documentation/git-commit.txt | 8 +++- buil