Re: [PATCH v5 2/8] read-cache: make_cache_entry should take object_id struct

> The make_cache_entry function should take an object_id struct instead > of sha. > diff --git a/read-cache.c b/read-cache.c > index fa8366ecab..9624ce1784 100644 > --- a/read-cache.c > +++ b/read-cache.c > @@ -746,8 +746,10 @@ int add_file_to_index(struct index_state *istate, const > char *path

Re: [PATCH v5 2/8] read-cache: make_cache_entry should take object_id struct

Jameson Miller writes: > The make_cache_entry function should take an object_id struct instead > of sha. The name of the hash is SHA-1, not sha ;-) It is not worth a reroll, but I do not think "should" is a particularly good thing to say in the title or justification in the log message in this

[PATCH v5 2/8] read-cache: make_cache_entry should take object_id struct

The make_cache_entry function should take an object_id struct instead of sha. Signed-off-by: Jameson Miller --- apply.c| 2 +- builtin/checkout.c | 2 +- builtin/difftool.c | 4 ++-- builtin/reset.c| 2 +- cache.h| 7 ++- merge-recursive.c | 2 +- read-cache.c