Re: [PATCH v5 2/4] commit test: Use write_script

2014-06-13 Thread Jeff King
On Fri, Jun 13, 2014 at 11:26:07AM -0500, Caleb Thompson wrote: > You're very right - I may have confused this commit message and the one > to switch to test_set_editor. I'll rewrite this commit message. > > What do you think of something like this for the description: > > Use write_script f

Re: [PATCH v5 2/4] commit test: Use write_script

2014-06-13 Thread Caleb Thompson
You're very right - I may have confused this commit message and the one to switch to test_set_editor. I'll rewrite this commit message. What do you think of something like this for the description: Use write_script from t/test-lib-functions.sh instead of cat, shebang, and chmod. This aids

Re: [PATCH v5 2/4] commit test: Use write_script

2014-06-12 Thread Jeff King
On Thu, Jun 12, 2014 at 02:39:00PM -0500, Caleb Thompson wrote: > Use write_script from t/test-lib-functions.sh instead of cat, shebang, > and chmod. This protects us from potential shell meta-characters in the > name of our trash directory, which would be interpreted if we set > $EDITOR directly.

[PATCH v5 2/4] commit test: Use write_script

2014-06-12 Thread Caleb Thompson
Use write_script from t/test-lib-functions.sh instead of cat, shebang, and chmod. This protects us from potential shell meta-characters in the name of our trash directory, which would be interpreted if we set $EDITOR directly. Signed-off-by: Caleb Thompson --- t/t7507-commit-verbose.sh | 6 ++---