Re: [PATCH v5 2/3] diff: add --diff-line-prefix option for passing in a prefix

2016-08-15 Thread Jacob Keller
On Mon, Aug 15, 2016 at 8:37 AM, Junio C Hamano wrote: > Jacob Keller writes: > >> I will look more into how to do the log version tomorrow, if I am >> still stuck I will re-work the patches as you suggest here. >> >> I am hoping I can find a good solution for how to handle it though. > > Thanks,

Re: [PATCH v5 2/3] diff: add --diff-line-prefix option for passing in a prefix

2016-08-15 Thread Junio C Hamano
Jacob Keller writes: > I will look more into how to do the log version tomorrow, if I am > still stuck I will re-work the patches as you suggest here. > > I am hoping I can find a good solution for how to handle it though. Thanks, I am hoping the same, too ;-) -- To unsubscribe from this list: s

Re: [PATCH v5 2/3] diff: add --diff-line-prefix option for passing in a prefix

2016-08-14 Thread Jacob Keller
On Sun, Aug 14, 2016 at 2:21 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> On Fri, Aug 12, 2016 at 2:58 PM, Junio C Hamano wrote: >>> On Fri, Aug 12, 2016 at 2:43 PM, Jacob Keller >>> wrote: Ok so the big problem here is that unlike with diff which has support for line-prefix

Re: [PATCH v5 2/3] diff: add --diff-line-prefix option for passing in a prefix

2016-08-14 Thread Junio C Hamano
Jacob Keller writes: > On Fri, Aug 12, 2016 at 2:58 PM, Junio C Hamano wrote: >> On Fri, Aug 12, 2016 at 2:43 PM, Jacob Keller wrote: >>> Ok so the big problem here is that unlike with diff which has support >>> for line-prefixes already due to needing it for graph mode, I can't >>> figure out

Re: [PATCH v5 2/3] diff: add --diff-line-prefix option for passing in a prefix

2016-08-12 Thread Jacob Keller
On Fri, Aug 12, 2016 at 2:21 PM, Jacob Keller wrote: > On Fri, Aug 12, 2016 at 2:15 PM, Junio C Hamano wrote: >> Otherwise, a "git log --graph -p --submodule=log-with-diff", when >> showing a commit in the superproject that changes submodule from >> commit A to commit B, wouldn't be able to run "

Re: [PATCH v5 2/3] diff: add --diff-line-prefix option for passing in a prefix

2016-08-12 Thread Jacob Keller
On Fri, Aug 12, 2016 at 2:15 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> The prefix shall come first prior to any other prefix associated with >> the --graph option or other source. >> >> Add tests for the same. >> >> Signed-off-by: Jacob Keller >> --- >> - v5 >> * Changed name to --di

Re: [PATCH v5 2/3] diff: add --diff-line-prefix option for passing in a prefix

2016-08-12 Thread Junio C Hamano
Jacob Keller writes: > The prefix shall come first prior to any other prefix associated with > the --graph option or other source. > > Add tests for the same. > > Signed-off-by: Jacob Keller > --- > - v5 > * Changed name to --diff-line-prefix since --line-prefix might indicate > for other comm

[PATCH v5 2/3] diff: add --diff-line-prefix option for passing in a prefix

2016-08-11 Thread Jacob Keller
From: Jacob Keller Add an option to pass additional prefix to be displayed before diff output. This feature will be used in a following patch to output correct --graph prefix when using a child_process/run_command interface for submodules. The prefix shall come first prior to any other prefix as