Re: [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values

2015-07-13 Thread Junio C Hamano
Heiko Voigt writes: > On Thu, Jul 09, 2015 at 01:00:10PM -0700, Junio C Hamano wrote: >> Jens Lehmann writes: >> >> > The git-submodule script doesn't need this and is fine using plain old >> > "git config", as by the time it is run the .gitmodules file is already >> > updated in the work tree.

Re: [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values

2015-07-13 Thread Heiko Voigt
On Thu, Jul 09, 2015 at 01:00:10PM -0700, Junio C Hamano wrote: > Jens Lehmann writes: > > >> How does git-submodule access this information? It looks like it just > >> hits "git config -f .gitmodules" directly. Perhaps whatever interface is > >> designed should be suitable for its use here (and

Re: [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values

2015-07-09 Thread Junio C Hamano
Jens Lehmann writes: >> How does git-submodule access this information? It looks like it just >> hits "git config -f .gitmodules" directly. Perhaps whatever interface is >> designed should be suitable for its use here (and if there really is no >> more interesting interface needed, then why is "g

Re: [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values

2015-07-09 Thread Jens Lehmann
Am 09.07.2015 um 17:49 schrieb Jeff King: On Thu, Jul 09, 2015 at 02:09:01PM +0200, Heiko Voigt wrote: Instead of test-submodule-config.c to test this new module, it could be useful to implement these as extensions to rev-parse: git rev-parse --submodule-name [:] git rev-parse --subm

Re: [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values

2015-07-09 Thread Jeff King
On Thu, Jul 09, 2015 at 02:09:01PM +0200, Heiko Voigt wrote: > > Instead of test-submodule-config.c to test this new module, it could > > be useful to implement these as extensions to rev-parse: > > > > git rev-parse --submodule-name [:] > > git rev-parse --submodule-path [:] > > git

Re: [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values

2015-07-09 Thread Heiko Voigt
On Wed, Jul 08, 2015 at 04:52:14PM -0400, Phil Hord wrote: > On Mon, Jun 15, 2015 at 5:06 PM, Heiko Voigt wrote: > > In a superproject some commands need to interact with submodules. They > > need to query values from the .gitmodules file either from the worktree > > of from certain revisions. At

Re: [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values

2015-07-08 Thread Phil Hord
On Mon, Jun 15, 2015 at 5:06 PM, Heiko Voigt wrote: > In a superproject some commands need to interact with submodules. They > need to query values from the .gitmodules file either from the worktree > of from certain revisions. At the moment this is quite hard since a > caller would need to read t

Re: [PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values

2015-06-16 Thread Heiko Voigt
On Mon, Jun 15, 2015 at 11:06:11PM +0200, Heiko Voigt wrote: > In a superproject some commands need to interact with submodules. They > need to query values from the .gitmodules file either from the worktree > of from certain revisions. At the moment this is quite hard since a > caller would need t

[PATCH v5 1/4] implement submodule config API for lookup of .gitmodules values

2015-06-15 Thread Heiko Voigt
In a superproject some commands need to interact with submodules. They need to query values from the .gitmodules file either from the worktree of from certain revisions. At the moment this is quite hard since a caller would need to read the .gitmodules file from the history and then parse the value