Re: [PATCH v5 1/3] format-patch: change erroneous and condition

Hi Junio, Thanks for the feedback. On Tue, Oct 15, 2019 at 11:16:35AM +0900, Junio C Hamano wrote: > Denton Liu writes: > > > Since this > > seems to be a Python-ism that's mistakenly leaked into our code, convert > > The conclusion is OK, but as the inventor of format-patch and a > non-p

Re: [PATCH v5 1/3] format-patch: change erroneous and condition

Denton Liu writes: > Since this > seems to be a Python-ism that's mistakenly leaked into our code, convert The conclusion is OK, but as the inventor of format-patch and a non-pythonista, I do not think the above claim is correct, and even if Thomas thought it was a good idea to follow Pytho

[PATCH v5 1/3] format-patch: change erroneous and condition

Commit 30984ed2e9 (format-patch: support deep threading, 2009-02-19), introduced the following lines: #define THREAD_SHALLOW 1 [...] thread = git_config_bool(var, value) && THREAD_SHALLOW; Since git_config_bool() returns a bool, the trailing `&& THREAD_SHALLOW` is a no-o