Re: [PATCH v5 1/1] http: Add Accept-Language header if possible

2014-12-03 Thread Michael Blume
On Wed, Dec 3, 2014 at 2:00 PM, Michael Blume wrote: > On Wed, Dec 3, 2014 at 1:37 PM, Junio C Hamano wrote: >> Eric Sunshine writes: >> @@ -515,6 +517,9 @@ void http_cleanup(void) cert_auth.password = NULL; } ssl_cert_password_required = 0; >>

Re: [PATCH v5 1/1] http: Add Accept-Language header if possible

2014-12-03 Thread Michael Blume
On Wed, Dec 3, 2014 at 1:37 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >>> @@ -515,6 +517,9 @@ void http_cleanup(void) >>> cert_auth.password = NULL; >>> } >>> ssl_cert_password_required = 0; >>> + >>> + if (cached_accept_language) >>> +

Re: [PATCH v5 1/1] http: Add Accept-Language header if possible

2014-12-03 Thread Junio C Hamano
Eric Sunshine writes: >> @@ -515,6 +517,9 @@ void http_cleanup(void) >> cert_auth.password = NULL; >> } >> ssl_cert_password_required = 0; >> + >> + if (cached_accept_language) >> + strbuf_release(cached_accept_language); > > Junio already menti

Re: [PATCH v5 1/1] http: Add Accept-Language header if possible

2014-12-03 Thread Eric Sunshine
On Tue, Dec 2, 2014 at 7:12 AM, Yi EungJun wrote: > From: Yi EungJun > > Add an Accept-Language header which indicates the user's preferred > languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. > > Examples: > LANGUAGE= -> "" > LANGUAGE=ko:en -> "Accept-Language: ko, en;q=0.9, *;

Re: [PATCH v5 1/1] http: Add Accept-Language header if possible

2014-12-03 Thread Junio C Hamano
Yi EungJun writes: > From: Yi EungJun > > Add an Accept-Language header which indicates the user's preferred > languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. > > Examples: > LANGUAGE= -> "" > LANGUAGE=ko:en -> "Accept-Language: ko, en;q=0.9, *;q=0.1" > LANGUAGE=ko LANG=en

[PATCH v5 1/1] http: Add Accept-Language header if possible

2014-12-02 Thread Yi EungJun
From: Yi EungJun Add an Accept-Language header which indicates the user's preferred languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. Examples: LANGUAGE= -> "" LANGUAGE=ko:en -> "Accept-Language: ko, en;q=0.9, *;q=0.1" LANGUAGE=ko LANG=en_US.UTF-8 -> "Accept-Language: ko, *;