Re: [PATCH v5 02/11] commit-graph: return with errors during write

2019-07-01 Thread Derrick Stolee
On 6/29/2019 1:23 PM, SZEDER Gábor wrote: > On Wed, Jun 12, 2019 at 06:29:37AM -0700, Derrick Stolee via GitGitGadget > wrote: >> diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh >> index e80c1cac02..3b6fd0d728 100755 >> --- a/t/t5318-commit-graph.sh >> +++ b/t/t5318-commit-graph.sh

Re: [PATCH v5 02/11] commit-graph: return with errors during write

2019-06-29 Thread SZEDER Gábor
On Wed, Jun 12, 2019 at 06:29:37AM -0700, Derrick Stolee via GitGitGadget wrote: > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh > index e80c1cac02..3b6fd0d728 100755 > --- a/t/t5318-commit-graph.sh > +++ b/t/t5318-commit-graph.sh > @@ -23,6 +23,14 @@ test_expect_success 'write gra

[PATCH v5 02/11] commit-graph: return with errors during write

2019-06-12 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method uses die() to report failure and exit when confronted with an unexpected condition. This use of die() in a library function is incorrect and is now replaced by error() statements and an int return type. Return zero on success and a negative val