Re: [PATCH v5 01/16] Git.pm: add subroutines for commenting lines

2016-11-09 Thread Junio C Hamano
Jakub Narębski writes: >> I prefer to have like this instead >> >> sub prefix_lines { >> my $prefix = shift; >> my $string = join("\n", @_); >> $string =~ s/^/$prefix/mg; >> return $string; >> } >> >> So both subroutines can take several strings as arguments. > >

Re: [PATCH v5 01/16] Git.pm: add subroutines for commenting lines

2016-11-09 Thread Jakub Narębski
W dniu 09.11.2016 o 18:02, Vasco Almeida pisze: > A Ter, 08-11-2016 às 17:06 -0800, Junio C Hamano escreveu: >> Vasco Almeida writes: >>> +sub comment_lines { >>> + my $comment_line_char = config("core.commentchar") || '#'; >>> + return prefix_lines("$comment_line_char ", @_); >>> +} >>> + >>

Re: [PATCH v5 01/16] Git.pm: add subroutines for commenting lines

2016-11-09 Thread Vasco Almeida
A Ter, 08-11-2016 às 17:06 -0800, Junio C Hamano escreveu: > Vasco Almeida writes: > > > > > Add subroutines prefix_lines and comment_lines. > > > > Signed-off-by: Vasco Almeida > > --- > >  perl/Git.pm | 23 +++ > >  1 file changed, 23 insertions(+) > > > > diff --git a/pe

Re: [PATCH v5 01/16] Git.pm: add subroutines for commenting lines

2016-11-08 Thread Junio C Hamano
Vasco Almeida writes: > Add subroutines prefix_lines and comment_lines. > > Signed-off-by: Vasco Almeida > --- > perl/Git.pm | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/perl/Git.pm b/perl/Git.pm > index b2732822a..17be59fb7 100644 > --- a/perl/Git.pm > +++

[PATCH v5 01/16] Git.pm: add subroutines for commenting lines

2016-11-08 Thread Vasco Almeida
Add subroutines prefix_lines and comment_lines. Signed-off-by: Vasco Almeida --- perl/Git.pm | 23 +++ 1 file changed, 23 insertions(+) diff --git a/perl/Git.pm b/perl/Git.pm index b2732822a..17be59fb7 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -1438,6 +1438,29 @@ sub END