Re: [PATCH v5 01/15] fast-export: avoid importing blob marks

2012-11-12 Thread Junio C Hamano
Jeff King writes: >> Major issue: "echo -n" is still not portable. >> >> Could we simply use >> >> touch marks-cur && >> touch marks-new > > Yes, "echo -n" is definitely not portable. Our preferred way of > creating an empty file is just ">file". Yes. And it is misleading to use "touch" i

Re: [PATCH v5 01/15] fast-export: avoid importing blob marks

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 5:36 PM, Torsten Bögershausen wrote: > On 11.11.12 14:59, Felipe Contreras wrote: >> test_expect_success 'test biridectionality' ' >> + echo -n > marks-cur && >> + echo -n > marks-new && > Unless I messed up the patch: > > Minor issue: still a typo "biridectionality

Re: [PATCH v5 01/15] fast-export: avoid importing blob marks

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 05:36:53PM +0100, Torsten Bögershausen wrote: > On 11.11.12 14:59, Felipe Contreras wrote: > > test_expect_success 'test biridectionality' ' > > + echo -n > marks-cur && > > + echo -n > marks-new && > Unless I messed up the patch: > > Minor issue: still a typo "biridec

Re: [PATCH v5 01/15] fast-export: avoid importing blob marks

2012-11-11 Thread Torsten Bögershausen
On 11.11.12 14:59, Felipe Contreras wrote: > test_expect_success 'test biridectionality' ' > + echo -n > marks-cur && > + echo -n > marks-new && Unless I messed up the patch: Minor issue: still a typo "biridectionality" Major issue: "echo -n" is still not portable. Could we simply use t

[PATCH v5 01/15] fast-export: avoid importing blob marks

2012-11-11 Thread Felipe Contreras
We want to be able to import, and then export, using the same marks, so that we don't push things that the other side already received. Unfortunately, fast-export doesn't store blobs in the marks, but fast-import does. This creates a mismatch when fast export is reusing a mark that was previously