Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread David Aguilar
On Sun, May 19, 2013 at 8:41 AM, Felipe Contreras wrote: > On Sun, May 19, 2013 at 10:13 AM, Ramkumar Ramachandra > wrote: >> Felipe Contreras wrote: >>> How exactly is it not equivalent to len = len || 1? >> >> Here, I dug up an article for you on the issue: >> >> http://www.rubyinside.com/what-

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread Felipe Contreras
On Sun, May 19, 2013 at 10:05 AM, Felipe Contreras wrote: > On Sun, May 19, 2013 at 9:40 AM, Ramkumar Ramachandra > wrote: >>> + '-L', '%u,+%u' % [start, len], >>> + '--since', $since, from + '^', >>> + '--', source]) do |p| >>> + p.each do |line| >

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread Felipe Contreras
On Sun, May 19, 2013 at 10:17 AM, Ramkumar Ramachandra wrote: > Ramkumar Ramachandra wrote: >> There's a non-optional space before the "" in your regex, which >> is what I was pointing out. > > Er, scratch that. It's the space after the "Whatevered-by:" It doesn't really matter. We can operate u

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread Felipe Contreras
On Sun, May 19, 2013 at 10:13 AM, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: >> How exactly is it not equivalent to len = len || 1? > > Here, I dug up an article for you on the issue: > > http://www.rubyinside.com/what-rubys-double-pipe-or-equals-really-does-5488.html > > Although it's

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: > There's a non-optional space before the "" in your regex, which > is what I was pointing out. Er, scratch that. It's the space after the "Whatevered-by:" -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kern

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread Ramkumar Ramachandra
Felipe Contreras wrote: >> Will $2 ever be nil (from fmt_person)? ie. Why are you checking for >> the special case " <\S+?>$"? > > Yes, '' was valid in earlier versions of git. There's a non-optional space before the "" in your regex, which is what I was pointing out. -- To unsubscribe from this

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread Ramkumar Ramachandra
Felipe Contreras wrote: > How exactly is it not equivalent to len = len || 1? Here, I dug up an article for you on the issue: http://www.rubyinside.com/what-rubys-double-pipe-or-equals-really-does-5488.html Although it's fine in this case, I wouldn't recommend using ||= because of the potential

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread Felipe Contreras
On Sun, May 19, 2013 at 9:40 AM, Ramkumar Ramachandra wrote: > Okay, let's look at this part. > > Felipe Contreras wrote: >> diff --git a/contrib/related/git-related b/contrib/related/git-related >> new file mode 100755 >> index 000..4f31482 >> --- /dev/null >> +++ b/contrib/related/git-relate

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread Ramkumar Ramachandra
Okay, let's look at this part. Felipe Contreras wrote: > diff --git a/contrib/related/git-related b/contrib/related/git-related > new file mode 100755 > index 000..4f31482 > --- /dev/null > +++ b/contrib/related/git-related > @@ -0,0 +1,124 @@ > +#!/usr/bin/env ruby > + > +# This script finds

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread Felipe Contreras
Junio C Hamano wrote: > Felipe Contreras writes: > > > On Sat, May 18, 2013 at 6:46 AM, Felipe Contreras > > wrote: > > > >> contrib/related/git-related | 124 > >> > >> 1 file changed, 124 insertions(+) > >> create mode 100755 contrib/related/git-

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-19 Thread Junio C Hamano
Felipe Contreras writes: > On Sat, May 18, 2013 at 6:46 AM, Felipe Contreras > wrote: > >> contrib/related/git-related | 124 >> >> 1 file changed, 124 insertions(+) >> create mode 100755 contrib/related/git-related > > I tried everything and I don

Re: [PATCH v5 01/15] Add new git-related helper to contrib

2013-05-18 Thread Felipe Contreras
On Sat, May 18, 2013 at 6:46 AM, Felipe Contreras wrote: > contrib/related/git-related | 124 > > 1 file changed, 124 insertions(+) > create mode 100755 contrib/related/git-related I tried everything and I don't think it's physically possible to ma

[PATCH v5 01/15] Add new git-related helper to contrib

2013-05-18 Thread Felipe Contreras
This script find people that might be interested in a patch, by going back through the history for each single hunk modified, and finding people that reviewed, acknowledge, signed, or authored the code the patch is modifying. It does this by running 'git blame' incrementally on each hunk, and then