On Sun, Feb 9, 2014 at 8:48 AM, Christian Couder
wrote:
> From: Junio C Hamano
>>
>> Christian Couder writes:
>>
>>> +static inline int same_trailer(struct trailer_item *a, struct trailer_item
>>> *b, int alnum_len)
>>> +{
>>> +return same_token(a, b, alnum_len) && same_value(a, b);
>>> +}
From: Junio C Hamano
>
> Christian Couder writes:
>
>> +enum action_if_exist if_exist;
>> +enum action_if_missing if_missing;
>
> Probably "if_exists" is more gramatically correct.
>
> if (x->if_exists) {
> ... do this ...
> }
>
> would read well, but not "x-
From: Junio C Hamano
>
> Christian Couder writes:
>
>> +enum action_where { WHERE_AFTER, WHERE_BEFORE };
>> +enum action_if_exist { EXIST_ADD_IF_DIFFERENT,
>> EXIST_ADD_IF_DIFFERENT_NEIGHBOR,
>> + EXIST_ADD, EXIST_OVERWRITE, EXIST_DO_NOTHING };
>> +enum action_if_missing { MIS
Christian Couder writes:
> + enum action_if_exist if_exist;
> + enum action_if_missing if_missing;
Probably "if_exists" is more gramatically correct.
if (x->if_exists) {
... do this ...
}
would read well, but not "x->if_exist".
--
To unsu
Christian Couder writes:
> We will use a doubly linked list to store all information
> about trailers and their configuration.
>
> This way we can easily remove or add trailers to or from
> trailer lists while traversing the lists in either direction.
>
> Signed-off-by: Christian Couder
> ---
>
We will use a doubly linked list to store all information
about trailers and their configuration.
This way we can easily remove or add trailers to or from
trailer lists while traversing the lists in either direction.
Signed-off-by: Christian Couder
---
Makefile | 1 +
trailer.c | 48 +
6 matches
Mail list logo
