Re: [PATCH v5 00/24] Remove submodule from files-backend.c

On 02/22/2017 03:04 PM, Nguyễn Thái Ngọc Duy wrote: > v5 goes a bit longer than v4, basically: I've reviewed all of the patches and left a bunch of comments, mostly superficial. I'm very happy about the way it's going, and especially want to say how much I appreciate that you've done so much legwo

Re: [PATCH v5 00/24] Remove submodule from files-backend.c

Michael Haggerty writes: > On 02/22/2017 03:04 PM, Nguyễn Thái Ngọc Duy wrote: >> v5 goes a bit longer than v4, basically: > > I've read through patch 14/24 so far, and they all look good except for > the mostly superficial comments that I have sent so far. I like the way > this is heading! > > I

Re: [PATCH v5 00/24] Remove submodule from files-backend.c

On 02/22/2017 03:04 PM, Nguyễn Thái Ngọc Duy wrote: > v5 goes a bit longer than v4, basically: I've read through patch 14/24 so far, and they all look good except for the mostly superficial comments that I have sent so far. I like the way this is heading! I'll try to continue tomorrow. Michael

Re: [PATCH v5 00/24] Remove submodule from files-backend.c

Junio C Hamano writes: > Nguyễn Thái Ngọc Duy writes: > >> v5 goes a bit longer than v4, basically: >> >> - files_path() is broken down into three smaller functions, >>files_{packed_refs,reflog,refname}_path(). >> >> - most of store-based api is added because.. >> >> - test-ref-store.c i

Re: [PATCH v5 00/24] Remove submodule from files-backend.c

Nguyễn Thái Ngọc Duy writes: > v5 goes a bit longer than v4, basically: > > - files_path() is broken down into three smaller functions, >files_{packed_refs,reflog,refname}_path(). > > - most of store-based api is added because.. > > - test-ref-store.c is added with t1405 and t1406 for som

[PATCH v5 00/24] Remove submodule from files-backend.c

v5 goes a bit longer than v4, basically: - files_path() is broken down into three smaller functions, files_{packed_refs,reflog,refname}_path(). - most of store-based api is added because.. - test-ref-store.c is added with t1405 and t1406 for some basic tests I'm not aimimg for complete