Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

2016-04-17 Thread Eric Sunshine
On Sun, Apr 17, 2016 at 1:34 PM, Santiago Torres wrote: > On Thu, Apr 07, 2016 at 12:19:37PM -0400, Eric Sunshine wrote: >> If you make any changes beyond the minor ones mentioned in my reviews >> or beyond plagiarizing commit message enhancements offered by my or >> Junio's reviews, then you'd al

Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

2016-04-17 Thread Santiago Torres
On Thu, Apr 07, 2016 at 12:19:37PM -0400, Eric Sunshine wrote: > On Wed, Apr 6, 2016 at 11:40 PM, Santiago Torres wrote: > >> > v5 (this): > >> > Added helpful feedback by Eric > >> > > >> > * Reordering of the patches, to avoid temporal inclusion of a regression > >> > * Fix typos here and ther

Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

2016-04-07 Thread Eric Sunshine
On Wed, Apr 6, 2016 at 11:40 PM, Santiago Torres wrote: >> > v5 (this): >> > Added helpful feedback by Eric >> > >> > * Reordering of the patches, to avoid temporal inclusion of a regression >> > * Fix typos here and there. >> > * Review commit messages, as some weren't representative of what t

Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

2016-04-06 Thread Santiago Torres
> > v5 (this): > > Added helpful feedback by Eric > > > > * Reordering of the patches, to avoid temporal inclusion of a regression > > * Fix typos here and there. > > * Review commit messages, as some weren't representative of what the > > patches > >were doing anymore. > > * Updated t7030

Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

2016-04-06 Thread Santiago Torres
Thanks for the reviews! I'll update the commit messages. It appears that I there's a lot to learn on my side on the art of writing good commit messages. -Santiago. On Wed, Apr 06, 2016 at 09:39:39AM -0700, Junio C Hamano wrote: > The first three looked almost good. I do not fully agree with wha

Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

2016-04-06 Thread Junio C Hamano
The first three looked almost good. I do not fully agree with what 4/6 does, and update to its function signature is likely to require updates to 5/6 and 6/6. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More major

Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

2016-04-06 Thread Eric Sunshine
On Tue, Apr 5, 2016 at 12:07 PM, wrote: > v5 (this): > Added helpful feedback by Eric > > * Reordering of the patches, to avoid temporal inclusion of a regression > * Fix typos here and there. > * Review commit messages, as some weren't representative of what the patches >were doing anymor

Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

2016-04-05 Thread Santiago Torres
Sorry, forgot to add, this is a follow on to [1]. Thanks, -Santiago. [1]: http://git.661346.n2.nabble.com/PATCH-v4-0-6-tag-move-PGP-verification-code-to-tag-c-td7652451.html On Tue, Apr 05, 2016 at 12:07:23PM -0400, santi...@nyu.edu wrote: > From: Santiago Torres > > v5 (this): > Added helpful

[PATCH v5 0/6] tag: move PGP verification code to tag.c

2016-04-05 Thread santiago
From: Santiago Torres v5 (this): Added helpful feedback by Eric * Reordering of the patches, to avoid temporal inclusion of a regression * Fix typos here and there. * Review commit messages, as some weren't representative of what the patches were doing anymore. * Updated t7030 to include