Re: [PATCH v5 0/4] submodule config lookup API

2015-08-12 Thread Junio C Hamano
Stefan Beller writes: > However just as I was convinced of my review and sent out the email, I started > working with it. And I found nits which I'd ask you to squash into the round > or > put on top. Good ;-). I'd prefer a full reroll, as it has been quite a while since v5 was originally post

Re: [PATCH v5 0/4] submodule config lookup API

2015-08-12 Thread Stefan Beller
On Wed, Aug 12, 2015 at 10:53 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Mon, Jun 15, 2015 at 2:48 PM, Junio C Hamano wrote: >>> Thanks. Will replace and wait for comments from others. >> >> I have reviewed the patches carefully and they look good to me. > > OK, I recall there we

Re: [PATCH v5 0/4] submodule config lookup API

2015-08-12 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Jun 15, 2015 at 2:48 PM, Junio C Hamano wrote: >> Thanks. Will replace and wait for comments from others. > > I have reviewed the patches carefully and they look good to me. OK, I recall there were a few iterations with review comments before this round. Is it

Re: [PATCH v5 0/4] submodule config lookup API

2015-08-10 Thread Stefan Beller
On Mon, Jun 15, 2015 at 2:48 PM, Junio C Hamano wrote: > Thanks. Will replace and wait for comments from others. I have reviewed the patches carefully and they look good to me. As Git is a large project and I was active in other parts until now, I noticed that there are subtle differences in st

Re: [PATCH v5 0/4] submodule config lookup API

2015-06-15 Thread Junio C Hamano
Thanks. Will replace and wait for comments from others. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v5 0/4] submodule config lookup API

2015-06-15 Thread Heiko Voigt
There have been no code changes in since the last iteration. I changed the title for the first patch since I realized that the cache is just an implementation detail and what we are really doing is to provide a new API for reading values from .gitmodules. I also added an extra paragraph in the comm