Re: [PATCH v5 0/4] commit: Add commit.verbose configuration

2014-06-16 Thread Junio C Hamano
Jeremiah Mahler writes: > On Fri, Jun 13, 2014 at 11:49:10AM -0500, Caleb Thompson wrote: > ... >> > The patches look good, they apply clean ('git am'), and all tests pass. >> > >> > Reviewed-by: Jeremiah Mahler >> >> So that I'm clear on the etiquitte, is it appropriate for me to add this >> R

Re: [PATCH v5 0/4] commit: Add commit.verbose configuration

2014-06-13 Thread Jeremiah Mahler
On Fri, Jun 13, 2014 at 11:49:10AM -0500, Caleb Thompson wrote: > On Thu, Jun 12, 2014 at 01:30:10PM -0700, Jeremiah Mahler wrote: > > On Thu, Jun 12, 2014 at 02:38:58PM -0500, Caleb Thompson wrote: > > > This patch allows people to set commit.verbose to implicitly send > > > --verbose to git-commi

Re: [PATCH v5 0/4] commit: Add commit.verbose configuration

2014-06-13 Thread Caleb Thompson
On Thu, Jun 12, 2014 at 01:30:10PM -0700, Jeremiah Mahler wrote: > On Thu, Jun 12, 2014 at 02:38:58PM -0500, Caleb Thompson wrote: > > This patch allows people to set commit.verbose to implicitly send > > --verbose to git-commit. > > > > This version incorporates changes suggested by Eric Sunshine,

Re: [PATCH v5 0/4] commit: Add commit.verbose configuration

2014-06-12 Thread Jeremiah Mahler
On Thu, Jun 12, 2014 at 02:38:58PM -0500, Caleb Thompson wrote: > This patch allows people to set commit.verbose to implicitly send > --verbose to git-commit. > > This version incorporates changes suggested by Eric Sunshine, Duy > Nguyen, and Jeremiah Mahler. > > It introduces several cleanup pat

[PATCH v5 0/4] commit: Add commit.verbose configuration

2014-06-12 Thread Caleb Thompson
This patch allows people to set commit.verbose to implicitly send --verbose to git-commit. This version incorporates changes suggested by Eric Sunshine, Duy Nguyen, and Jeremiah Mahler. It introduces several cleanup patches to t/t7505-commit-verbose.sh to bring it closer to the current state of t