Re: [PATCH v5 0/2] bisect--helper: rewrite of check-term-format()

2016-05-19 Thread Pranit Bauva
Hey Eric, Sorry for the late reply. I was on vacation. On Mon, May 16, 2016 at 6:05 AM, Eric Sunshine wrote: > On Sun, May 8, 2016 at 9:34 AM, Pranit Bauva wrote: >> On Sun, May 8, 2016 at 11:53 AM, Pranit Bauva wrote: >>> On Sun, May 8, 2016 at 7:55 AM, Junio C Hamano wrote: Pranit Bauva

Re: [PATCH v5 0/2] bisect--helper: rewrite of check-term-format()

2016-05-16 Thread Christian Couder
On Mon, May 16, 2016 at 2:35 AM, Eric Sunshine wrote: > On Sun, May 8, 2016 at 9:34 AM, Pranit Bauva wrote: >> On Sun, May 8, 2016 at 11:53 AM, Pranit Bauva wrote: >>> On Sun, May 8, 2016 at 7:55 AM, Junio C Hamano wrote: Pranit Bauva writes: > I completely missed your point and you w

Re: [PATCH v5 0/2] bisect--helper: rewrite of check-term-format()

2016-05-15 Thread Eric Sunshine
On Sun, May 8, 2016 at 9:34 AM, Pranit Bauva wrote: > On Sun, May 8, 2016 at 11:53 AM, Pranit Bauva wrote: >> On Sun, May 8, 2016 at 7:55 AM, Junio C Hamano wrote: >>> Pranit Bauva writes: I completely missed your point and you want me to go the Eric Sunshine's way? >>> >>> I am neut

Re: [PATCH v5 0/2] bisect--helper: rewrite of check-term-format()

2016-05-08 Thread Pranit Bauva
On Sun, May 8, 2016 at 11:53 AM, Pranit Bauva wrote: > On Sun, May 8, 2016 at 7:55 AM, Junio C Hamano wrote: >> Pranit Bauva writes: >> >>> I completely missed your point and you want me to go the Eric Sunshine's >>> way? >> >> I am neutral. >> >> When I read your response to Eric's "top down"

Re: [PATCH v5 0/2] bisect--helper: rewrite of check-term-format()

2016-05-07 Thread Pranit Bauva
On Sun, May 8, 2016 at 7:55 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> I completely missed your point and you want me to go the Eric Sunshine's way? > > I am neutral. > > When I read your response to Eric's "top down" suggestion, I didn't > quite get much more than "I started going thi

Re: [PATCH v5 0/2] bisect--helper: rewrite of check-term-format()

2016-05-07 Thread Junio C Hamano
Pranit Bauva writes: > I completely missed your point and you want me to go the Eric Sunshine's way? I am neutral. When I read your response to Eric's "top down" suggestion, I didn't quite get much more than "I started going this way, and I do not want to change to the other direction.", which

Re: [PATCH v5 0/2] bisect--helper: rewrite of check-term-format()

2016-05-07 Thread Pranit Bauva
On Sat, May 7, 2016 at 3:45 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> A very interesting fact to note: >> I made a mistake by dropping of the first argument 'term' in the function >> one_of() and compiled and the test suite passed fully (which was pointed >> out by Christian). This sh

Re: [PATCH v5 0/2] bisect--helper: rewrite of check-term-format()

2016-05-06 Thread Junio C Hamano
Pranit Bauva writes: > A very interesting fact to note: > I made a mistake by dropping of the first argument 'term' in the function > one_of() and compiled and the test suite passed fully (which was pointed > out by Christian). This shows that the test coverage is incomplete. > I am > currently

[PATCH v5 0/2] bisect--helper: rewrite of check-term-format()

2016-05-06 Thread Pranit Bauva
A very interesting fact to note: I made a mistake by dropping of the first argument 'term' in the function one_of() and compiled and the test suite passed fully (which was pointed out by Christian). This shows that the test coverage is incomplete. I am currently writing tests to improve on that cov