Re: [PATCH v5] upload-pack.c: use parse-options API

2016-06-01 Thread Antoine Queru
> Matthieu Moy writes: > > > Actually, that's even: don't you want to use a valid email address in > > your Signed-off-by: ? ;-) > > > > @ensimag.grenoble-inp.fr => student's current adress > > @grenoble-inp.org => students lifelong address. If not already done, > > students

Re: [PATCH v5] upload-pack.c: use parse-options API

2016-05-31 Thread Junio C Hamano
Matthieu Moy writes: > Actually, that's even: don't you want to use a valid email address in > your Signed-off-by: ? ;-) > > @ensimag.grenoble-inp.fr => student's current adress > @grenoble-inp.org => students lifelong address. If not already done, > students can already set

Re: [PATCH v5] upload-pack.c: use parse-options API

2016-05-31 Thread Matthieu Moy
Junio C Hamano writes: > Antoine Queru writes: > >> From: Antoine Queru >> Signed-off-by: Antoine Queru > > Don't you want to be known to the project as the email that matches > your Signed-off-by: line? Actually, that's even: don't you want to use a valid email address in your Signed-off-by:

Re: [PATCH v5] upload-pack.c: use parse-options API

2016-05-31 Thread Antoine Queru
Hello Junio, thanks for your answer. The next version (and hopefully the last) will come fast. > > From: Antoine Queru > > Don't you want to be known to the project as the email that matches > your Signed-off-by: line? Thanks for noticing it, it will be updated. > > +--[no-]strict:: > > D

Re: [PATCH v5] upload-pack.c: use parse-options API

2016-05-30 Thread Junio C Hamano
Antoine Queru writes: > From: Antoine Queru Don't you want to be known to the project as the email that matches your Signed-off-by: line? > Use the parse-options API rather than a hand-rolled option parser. > > Description for --stateless-rpc and --advertise-refs come from > 42526b4 (Add state

Re: [PATCH v5] upload-pack.c: use parse-options API

2016-05-30 Thread Matthieu Moy
Antoine Queru writes: > From: Antoine Queru [ Insert here the sentence I've been repeating a lot lately about this useless From ;-) ] > Documentation/git-upload-pack.txt | 16 +-- > upload-pack.c | 59 > +-- > 2 files changed,

[PATCH v5] upload-pack.c: use parse-options API

2016-05-30 Thread Antoine Queru
From: Antoine Queru Use the parse-options API rather than a hand-rolled option parser. Description for --stateless-rpc and --advertise-refs come from 42526b4 (Add stateless RPC options to upload-pack, receive-pack, 2009-10-30). Signed-off-by: Antoine Queru Signed-off-by: Matthieu Moy --- Chan