Re: [PATCH v5] Add an explicit GIT_DIR to the list of excludes

On Tue, Jun 10, 2014 at 10:18 AM, Pasha Bolokhov wrote: >> On Thu, Jun 5, 2014 at 3:15 AM, Pasha Bolokhov >> wrote: >>> + /* only add it if GIT_DIR does not end with '.git' or '/.git' */ >>> + if (len < 4 || strcmp(n_git + len - 4, ".git") || >>> + (len > 4 && n_git[len - 5

Re: [PATCH v5] Add an explicit GIT_DIR to the list of excludes

> On Thu, Jun 5, 2014 at 3:15 AM, Pasha Bolokhov > wrote: >> + /* only add it if GIT_DIR does not end with '.git' or '/.git' */ >> + if (len < 4 || strcmp(n_git + len - 4, ".git") || >> + (len > 4 && n_git[len - 5] != '/')) { > > Hmm.. should we exclude "foobar.git" as well?

Re: [PATCH v5] Add an explicit GIT_DIR to the list of excludes

On Thu, Jun 5, 2014 at 3:15 AM, Pasha Bolokhov wrote: > + /* only add it if GIT_DIR does not end with '.git' or '/.git' */ > + if (len < 4 || strcmp(n_git + len - 4, ".git") || > + (len > 4 && n_git[len - 5] != '/')) { Hmm.. should we exclude "foobar.git" as well? -- Duy --

[PATCH v5] Add an explicit GIT_DIR to the list of excludes

When an explicit '--git-dir' option points to a directory inside the work tree, git treats it as if it were any other directory. In particular, 'git status' lists it as untracked, while 'git add -A' stages the metadata directory entirely Add GIT_DIR to the list of excludes in a dedicated function