Re: [PATCH v4 6/8] branch.c: use 'ref-filter' data structures

2015-09-13 Thread Matthieu Moy
Karthik Nayak writes: > On Sun, Sep 13, 2015 at 5:56 PM, Matthieu Moy > wrote: >> Karthik Nayak writes: >> >>> /* Print detached HEAD before sorting and printing the rest */ >>> - if (detached) { >>> - print_ref_item(&ref_list.list[index - 1], maxwidth, verbose, >>> abbre

Re: [PATCH v4 6/8] branch.c: use 'ref-filter' data structures

2015-09-13 Thread Karthik Nayak
On Sun, Sep 13, 2015 at 5:56 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> /* Print detached HEAD before sorting and printing the rest */ >> - if (detached) { >> - print_ref_item(&ref_list.list[index - 1], maxwidth, verbose, >> abbrev, >> -

Re: [PATCH v4 6/8] branch.c: use 'ref-filter' data structures

2015-09-13 Thread Matthieu Moy
Karthik Nayak writes: > /* Print detached HEAD before sorting and printing the rest */ > - if (detached) { > - print_ref_item(&ref_list.list[index - 1], maxwidth, verbose, > abbrev, > -detached, remote_prefix); > - index -= 1; > +

Re: [PATCH v4 6/8] branch.c: use 'ref-filter' data structures

2015-09-13 Thread Karthik Nayak
On Sun, Sep 13, 2015 at 12:53 PM, Karthik Nayak wrote: > Make 'branch.c' use 'ref-filter' APIs for iterating through refs > sorting. This removes most of the code used in 'branch.c' replacing it > with calls to the 'ref-filter' library. > > Make 'branch.c' use the 'filter_refs()' function provided

[PATCH v4 6/8] branch.c: use 'ref-filter' data structures

2015-09-13 Thread Karthik Nayak
Make 'branch.c' use 'ref-filter' APIs for iterating through refs sorting. This removes most of the code used in 'branch.c' replacing it with calls to the 'ref-filter' library. Make 'branch.c' use the 'filter_refs()' function provided by 'ref-filter' to filter out tags based on the options set. We

[PATCH v4 6/8] branch.c: use 'ref-filter' data structures

2015-09-13 Thread Karthik Nayak
Make 'branch.c' use 'ref-filter' data structures and make changes to support the new data structures. This is a part of the process of porting 'branch.c' to use 'ref-filter' APIs. This is a temporary step before porting 'branch.c' to use 'ref-filter' completely. As this is a temporary step, most o