Re: [PATCH v4 5/8] branch: drop non-commit error reporting

2015-09-15 Thread Karthik Nayak
On Tue, Sep 15, 2015 at 1:19 AM, Junio C Hamano wrote: > Karthik Nayak writes: > >> Remove the error reporting variable to make the code easier to port >> over to using ref-filter APIs. This variable is not required as in >> ref-filter we already check for possible errors and report them. > > Hmm

Re: [PATCH v4 5/8] branch: drop non-commit error reporting

2015-09-14 Thread Junio C Hamano
Karthik Nayak writes: > Remove the error reporting variable to make the code easier to port > over to using ref-filter APIs. This variable is not required as in > ref-filter we already check for possible errors and report them. H. What do you exactly mean "possible errors" here? Unlike gen

[PATCH v4 5/8] branch: drop non-commit error reporting

2015-09-13 Thread Karthik Nayak
Remove the error reporting variable to make the code easier to port over to using ref-filter APIs. This variable is not required as in ref-filter we already check for possible errors and report them. Based-on-patch-by: Jeff King Mentored-by: Christian Couder Mentored-by: Matthieu Moy Signed-off