Re: [PATCH v4 4/4] format-patch: introduce format.base configuration

2016-04-13 Thread Ye Xiaolong
On Tue, Apr 12, 2016 at 12:47:23PM -0700, Junio C Hamano wrote: >Xiaolong Ye writes: > >> +static int config_base_commit; > >This variable is used as a simple boolean whose name is overly broad >(if it were named "config_base_auto" this complaint would not >apply). If you envision possible future

Re: [PATCH v4 4/4] format-patch: introduce format.base configuration

2016-04-12 Thread Junio C Hamano
Xiaolong Ye writes: > +static int config_base_commit; This variable is used as a simple boolean whose name is overly broad (if it were named "config_base_auto" this complaint would not apply). If you envision possible future enhancements for this configuration variable, "int config_base_commit"

[PATCH v4 4/4] format-patch: introduce format.base configuration

2016-04-10 Thread Xiaolong Ye
We can set format.base=auto to record the base commit info automatically, it is equivalent to set --base=auto in cmdline. The format.base has lower priority than command line option, so if user set format.base=auto and pass the command line option in the meantime, base_commit will be the one passe