Re: [PATCH v4 38/44] builtin-am: support and auto-detect StGit patches

2015-07-01 Thread Paul Tan
On Tue, Jun 30, 2015 at 5:39 AM, Junio C Hamano wrote: > Not using any increment inside isspace(), like you showed, is the > most readable. Yup, I agree. Thanks, Paul -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH v4 38/44] builtin-am: support and auto-detect StGit patches

2015-06-29 Thread Junio C Hamano
Eric Sunshine writes: > On Mon, Jun 29, 2015 at 4:42 PM, Stefan Beller wrote: >> On Sun, Jun 28, 2015 at 7:06 AM, Paul Tan wrote: >>> +/** >>> + * Returns true if `str` consists of only whitespace, false otherwise. >>> + */ >>> +static int str_isspace(const char *str) >>> +{ >>> + while (

Re: [PATCH v4 38/44] builtin-am: support and auto-detect StGit patches

2015-06-29 Thread Eric Sunshine
On Mon, Jun 29, 2015 at 4:42 PM, Stefan Beller wrote: > On Sun, Jun 28, 2015 at 7:06 AM, Paul Tan wrote: >> +/** >> + * Returns true if `str` consists of only whitespace, false otherwise. >> + */ >> +static int str_isspace(const char *str) >> +{ >> + while (*str) >> + if (!iss

Re: [PATCH v4 38/44] builtin-am: support and auto-detect StGit patches

2015-06-29 Thread Stefan Beller
On Sun, Jun 28, 2015 at 7:06 AM, Paul Tan wrote: > Since c574e68 (git-am foreign patch support: StGIT support, 2009-05-27), > git-am.sh supported converting StGit patches into RFC2822 mail patches > that can be parsed with git-mailinfo. > > Implement this by introducing two functions in builtin/am

[PATCH v4 38/44] builtin-am: support and auto-detect StGit patches

2015-06-28 Thread Paul Tan
Since c574e68 (git-am foreign patch support: StGIT support, 2009-05-27), git-am.sh supported converting StGit patches into RFC2822 mail patches that can be parsed with git-mailinfo. Implement this by introducing two functions in builtin/am.c: stgit_patch_to_mail() and split_mail_conv(). stgit_pat