Re: [PATCH v4 3/6] rebase -i: support --committer-date-is-author-date

2019-10-06 Thread Rohit Ashiwal
On Fri, 4 Oct 2019 10:37:43 +0100 Phillip Wood wrote: > > > + if (opts->committer_date_is_author_date) { > > + int len = strlen(author); > > + struct ident_split ident; > > + struct strbuf date = STRBUF_INIT; > > + > > + if (split_ident_line(&ident, autho

Re: [PATCH v4 3/6] rebase -i: support --committer-date-is-author-date

2019-10-04 Thread Phillip Wood
Hi Rohit The handling of ident_split is looking better now but I've got a question below about returning vs going to a cleanup section when there's an error. On 07/09/2019 12:50, Rohit Ashiwal wrote: rebase am already has this flag to "lie" about the committer date by changing it to the auth

[PATCH v4 3/6] rebase -i: support --committer-date-is-author-date

2019-09-07 Thread Rohit Ashiwal
rebase am already has this flag to "lie" about the committer date by changing it to the author date. Let's add the same for interactive machinery. Signed-off-by: Rohit Ashiwal --- Documentation/git-rebase.txt| 10 ++-- builtin/rebase.c| 17 +-- sequencer.c