Re: [PATCH v4 3/4] imap_send: setup_curl: retreive credentials if not set in config file

2017-09-14 Thread Junio C Hamano
Nicolas Morey-Chaisemartin writes: > > + if (cred.username) > + if (res == CURLE_OK) > + credential_approve(&cred); > +#if LIBCURL_VERSION_NUM >= 0x070d01 > + else if (res == CURLE_LOGIN_DENIED) > +#else > + else > +#endif > +

Re: [PATCH v4 3/4] imap_send: setup_curl: retreive credentials if not set in config file

2017-09-14 Thread Junio C Hamano
Nicolas Morey-Chaisemartin writes: > + if (cred.username) > + if (res == CURLE_OK) > + credential_approve(&cred); > +#if LIBCURL_VERSION_NUM >= 0x070d01 > + else if (res == CURLE_LOGIN_DENIED) A slight tangent. This is in line with the way in whic

[PATCH v4 3/4] imap_send: setup_curl: retreive credentials if not set in config file

2017-09-14 Thread Nicolas Morey-Chaisemartin
Up to this point, the curl mode only supported getting the username and password from the gitconfig file while the legacy mode could also fetch them using the credential API. Signed-off-by: Nicolas Morey-Chaisemartin --- imap-send.c | 18 -- 1 file changed, 16 insertions(+), 2 de