Re: [PATCH v4 3/3] submodule: simplify decision tree whether to or not to fetch

2017-10-19 Thread Brandon Williams
On 10/19, Heiko Voigt wrote: > On Thu, Oct 19, 2017 at 09:36:47AM +0900, Junio C Hamano wrote: > > Brandon Williams writes: > > > > > On 10/16, Heiko Voigt wrote: > > >> To make extending this logic later easier. > > > > > > This makes things so much clearer, thanks! > > > > I agree that it is c

Re: [PATCH v4 3/3] submodule: simplify decision tree whether to or not to fetch

2017-10-19 Thread Heiko Voigt
On Thu, Oct 19, 2017 at 09:36:47AM +0900, Junio C Hamano wrote: > Brandon Williams writes: > > > On 10/16, Heiko Voigt wrote: > >> To make extending this logic later easier. > > > > This makes things so much clearer, thanks! > > I agree that it is clear to see what the code after the patch does,

Re: [PATCH v4 3/3] submodule: simplify decision tree whether to or not to fetch

2017-10-18 Thread Junio C Hamano
Brandon Williams writes: > On 10/16, Heiko Voigt wrote: >> To make extending this logic later easier. > > This makes things so much clearer, thanks! I agree that it is clear to see what the code after the patch does, but the code before the patch is so convoluted to follow that it is a bit hard

Re: [PATCH v4 3/3] submodule: simplify decision tree whether to or not to fetch

2017-10-18 Thread Brandon Williams
On 10/16, Heiko Voigt wrote: > To make extending this logic later easier. This makes things so much clearer, thanks! > > Signed-off-by: Heiko Voigt > --- > submodule.c | 74 > ++--- > 1 file changed, 37 insertions(+), 37 deletions(-) >

Re: [PATCH v4 3/3] submodule: simplify decision tree whether to or not to fetch

2017-10-17 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Oct 16, 2017 at 6:59 AM, Heiko Voigt wrote: >> To make extending this logic later easier. >> >> Signed-off-by: Heiko Voigt > > Thanks for this readability fix! > > Stefan Thanks, both.

Re: [PATCH v4 3/3] submodule: simplify decision tree whether to or not to fetch

2017-10-17 Thread Stefan Beller
On Mon, Oct 16, 2017 at 6:59 AM, Heiko Voigt wrote: > To make extending this logic later easier. > > Signed-off-by: Heiko Voigt Thanks for this readability fix! Stefan

[PATCH v4 3/3] submodule: simplify decision tree whether to or not to fetch

2017-10-16 Thread Heiko Voigt
To make extending this logic later easier. Signed-off-by: Heiko Voigt --- submodule.c | 74 ++--- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/submodule.c b/submodule.c index 71d1773e2e..82d206eb65 100644 --- a/submodule.