Re: [PATCH v4 3/3] Add colors to interactive git-clean

2013-05-02 Thread Jiang Xin
2013/5/2 Matthieu Moy : > Jiang Xin writes: > >> Show help, error messages, and prompt in colors for interactive >> git-clean. > > I find the red WARNING a bit agressive. Also, the NOTE: is the same > color as the WARNING, hence visually similar. I first thought it was > repeating the same message

Re: [PATCH v4 3/3] Add colors to interactive git-clean

2013-05-02 Thread Matthieu Moy
Jiang Xin writes: > Show help, error messages, and prompt in colors for interactive > git-clean. I find the red WARNING a bit agressive. Also, the NOTE: is the same color as the WARNING, hence visually similar. I first thought it was repeating the same message. I think it would make more sense t

[PATCH v4 3/3] Add colors to interactive git-clean

2013-05-02 Thread Jiang Xin
Show help, error messages, and prompt in colors for interactive git-clean. Re-use config variables from git-add--interactive: * color.interactive: When set to always, always use colors for interactive prompts and displays. When false (or never), never. When set to true or auto, use colors o