Re: [PATCH v4 23/26] initdb: move safe_create_dir into common code

2015-10-21 Thread Junio C Hamano
David Turner writes: > In a moment, we'll create initdb functions for ref backends, and code > from initdb that calls this function needs to move into the files > backend. So this function needs to be public. OK, but unlike the static function, being in public interface part can invite mistakes

Re: [PATCH v4 23/26] initdb: move safe_create_dir into common code

2015-10-21 Thread David Turner
On Wed, 2015-10-21 at 12:38 -0700, Junio C Hamano wrote: > David Turner writes: > > > In a moment, we'll create initdb functions for ref backends, and code > > from initdb that calls this function needs to move into the files > > backend. So this function needs to be public. > > OK, but unlike

[PATCH v4 23/26] initdb: move safe_create_dir into common code

2015-10-15 Thread David Turner
In a moment, we'll create initdb functions for ref backends, and code from initdb that calls this function needs to move into the files backend. So this function needs to be public. Signed-off-by: David Turner Signed-off-by: Junio C Hamano Signed-off-by: Michael Haggerty --- builtin/init-db.c