Re: [PATCH v4 2/4] git-submodule init: Record submodule..branch in repository config.

2012-11-27 Thread W. Trevor King
On Wed, Nov 28, 2012 at 12:19:04AM +0100, Jens Lehmann wrote: > Am 26.11.2012 22:00, schrieb W. Trevor King: > > From: "W. Trevor King" > > > > This allows users to override the .gitmodules value with a > > per-repository value. > > [snip problems]. You should use the branch setting from .git/c

Re: [PATCH v4 2/4] git-submodule init: Record submodule..branch in repository config.

2012-11-27 Thread Jens Lehmann
Am 26.11.2012 22:00, schrieb W. Trevor King: > From: "W. Trevor King" > > This allows users to override the .gitmodules value with a > per-repository value. Your intentions makes lots of sense, but your patch does more than that. Copying the branch setting into .git/config sets the initial branc

[PATCH v4 2/4] git-submodule init: Record submodule..branch in repository config.

2012-11-26 Thread W. Trevor King
From: "W. Trevor King" This allows users to override the .gitmodules value with a per-repository value. Signed-off-by: W. Trevor King --- Documentation/config.txt | 9 + git-submodule.sh | 7 +++ t/t7400-submodule-basic.sh | 18 ++ 3 files changed, 30