Re: [PATCH v4 2/4] diff: introduce diff.submodule configuration variable

2012-11-22 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: > Junio C Hamano wrote: >> Ramkumar Ramachandra writes: >>> +test_expect_success 'added submodule, set diff.submodule' " >> >> s/added/add/; > > I see that the topic is already in `next`. Do you want to fix it up there? I was simply following the example set by the pr

Re: [PATCH v4 2/4] diff: introduce diff.submodule configuration variable

2012-11-22 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > Ramkumar Ramachandra writes: > >> diff --git a/t/t4041-diff-submodule-option.sh >> b/t/t4041-diff-submodule-option.sh >> index 6c01d0c..e401814 100755 >> --- a/t/t4041-diff-submodule-option.sh >> +++ b/t/t4041-diff-submodule-option.sh >> @@ -33,6 +33,7 @@ test_create_repo

Re: [PATCH v4 2/4] diff: introduce diff.submodule configuration variable

2012-11-19 Thread Junio C Hamano
Ramkumar Ramachandra writes: > diff --git a/t/t4041-diff-submodule-option.sh > b/t/t4041-diff-submodule-option.sh > index 6c01d0c..e401814 100755 > --- a/t/t4041-diff-submodule-option.sh > +++ b/t/t4041-diff-submodule-option.sh > @@ -33,6 +33,7 @@ test_create_repo sm1 && > add_file . foo >/dev/

[PATCH v4 2/4] diff: introduce diff.submodule configuration variable

2012-11-13 Thread Ramkumar Ramachandra
Introduce a diff.submodule configuration variable corresponding to the '--submodule' command-line option of 'git diff'. Signed-off-by: Ramkumar Ramachandra --- Documentation/diff-config.txt|7 +++ Documentation/diff-options.txt |3 ++- diff.c | 32 ++